CpuProfiler: public API for deopt info in cpu profiler.

include/v8-profiler.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_V8_PROFILER_H_
 #define V8_V8_PROFILER_H_
 
+#include <vector>
 #include "v8.h"
 
 /**
  * Profiler support for the V8 JavaScript engine.
  */
 namespace v8 {
 
 class HeapGraphNode;
 struct HeapStatsUpdate;
 
 typedef uint32_t SnapshotObjectId;
 
+
+struct V8_EXPORT CpuProfileDeoptInfo {
+  struct Frame {
+    int script_id;
+    unsigned int position;

[yurys, 2015/03/30 20:33:15]

unsigned int -> unsigned

[Sven Panne, 2015/03/31 06:27:09]

I think that size_t is the right type here, isn't it? It might be the case that
we have wrong types internally, but at least we should get things right on the
external API.

[yurys, 2015/03/31 06:53:49]

Agree, size_t would be even better.

[loislo, 2015/03/31 08:22:51]

done

+  };
+  const char* deopt_reason;

[Sven Panne, 2015/03/31 06:27:09]

Add a comment about ownership here, naked pointer are always a bit vague...

[loislo, 2015/03/31 08:22:51]

done

+  std::vector<Frame> stack;
+};
+
+
 /**
  * CpuProfileNode represents a node in a call graph.
  */
 class V8_EXPORT CpuProfileNode {
  public:
   struct LineTick {
     /** The 1-based number of the source line where the function originates. */
     int line;
 
     /** The count of samples associated with the source line. */
@@ skipping 48 matching lines @@
 
   /** Returns id of the node. The id is unique within the tree */
   unsigned GetNodeId() const;
 
   /** Returns child nodes count of the node. */
   int GetChildrenCount() const;
 
   /** Retrieves a child node by index. */
   const CpuProfileNode* GetChild(int index) const;
 
+  /** Retrieves deopt infos for the node. */
+  const std::vector<CpuProfileDeoptInfo>& GetDeoptInfos() const;
+
   static const int kNoLineNumberInfo = Message::kNoLineNumberInfo;
   static const int kNoColumnNumberInfo = Message::kNoColumnInfo;
 };
 
 
 /**
  * CpuProfile contains a CPU profile in a form of top-down call tree
  * (from main() down to functions that do all the work).
  */
 class V8_EXPORT CpuProfile {
@@ skipping 507 matching lines @@
   uint32_t index;  // Index of the time interval that was changed.
   uint32_t count;  // New value of count field for the interval with this index.
   uint32_t size;  // New value of size field for the interval with this index.
 };
 
 
 }  // namespace v8
 
 
 #endif  // V8_V8_PROFILER_H_