Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1045573002: Add a Subzero configuration to LLVM testsuite bot testing. x86-32 only. (Closed)

Created:
5 years, 9 months ago by Jim Stichnoth
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M buildbot/buildbot_pnacl_toolchain_tests.sh View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 9 months ago (2015-03-29 04:03:40 UTC) #2
JF
lgtm https://codereview.chromium.org/1045573002/diff/1/buildbot/buildbot_pnacl_toolchain_tests.sh File buildbot/buildbot_pnacl_toolchain_tests.sh (right): https://codereview.chromium.org/1045573002/diff/1/buildbot/buildbot_pnacl_toolchain_tests.sh#newcode200 buildbot/buildbot_pnacl_toolchain_tests.sh:200: # For now, this means running 2 combinations ...
5 years, 8 months ago (2015-03-29 05:48:10 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/1045573002/diff/1/buildbot/buildbot_pnacl_toolchain_tests.sh File buildbot/buildbot_pnacl_toolchain_tests.sh (right): https://codereview.chromium.org/1045573002/diff/1/buildbot/buildbot_pnacl_toolchain_tests.sh#newcode200 buildbot/buildbot_pnacl_toolchain_tests.sh:200: # For now, this means running 2 combinations for ...
5 years, 8 months ago (2015-03-29 22:35:14 UTC) #4
Jim Stichnoth
5 years, 8 months ago (2015-03-29 22:35:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
465702e566ce97e120dfd526a5b5c687f794ba89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698