Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3734)

Unified Diff: buildbot/buildbot_pnacl_toolchain_tests.sh

Issue 1045573002: Add a Subzero configuration to LLVM testsuite bot testing. x86-32 only. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Update comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/buildbot_pnacl_toolchain_tests.sh
diff --git a/buildbot/buildbot_pnacl_toolchain_tests.sh b/buildbot/buildbot_pnacl_toolchain_tests.sh
index e1968264db980afc9e786d41aa55b5aefa3fa6b5..fd72baa17f5c67fa1f44417748497a1ceec501ed 100755
--- a/buildbot/buildbot_pnacl_toolchain_tests.sh
+++ b/buildbot/buildbot_pnacl_toolchain_tests.sh
@@ -196,13 +196,17 @@ tc-test-bot() {
local optset
optset[1]="--opt O3f --opt O2b"
for arch in ${archset}; do
- # Run all appropriate frontend/backend optimization combinations.
- # For now, this means running 2 combinations for x86 since each
- # takes about 20 minutes on the bots, and making a single run
- # elsewhere since e.g. arm takes about 75 minutes. In a perfect
- # world, all 4 combinations would be run.
+ # Run all appropriate frontend/backend optimization combinations. For now,
+ # this means running 2 combinations for x86 (plus one more for Subzero on
+ # x86-32) since each takes about 20 minutes on the bots, and making a single
+ # run elsewhere since e.g. arm takes about 75 minutes. In a perfect world,
+ # all 4 combinations would be run, plus more for Subzero.
if [[ ${archset} =~ x86 ]]; then
optset[2]="--opt O3f --opt O0b"
+ if [[ ${archset} == x86-32 ]]; then
+ # Run a Subzero -O2 test set on x86-32.
+ optset[3]="--opt O3f --opt O2b_sz"
+ fi
fi
for opt in "${optset[@]}"; do
echo "@@@BUILD_STEP llvm-test-suite ${arch} ${opt} @@@"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698