Issue 1045353002: Avoid srcset upscaling for 1x DPR scenarios

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045353002: Avoid srcset upscaling for 1x DPR scenarios (Closed)

Created:
5 years, 8 months ago by Yoav Weiss

Modified:
5 years, 8 months ago

Reviewers:
Mike West

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Avoid srcset upscaling for 1x DPR scenarios Due to complaints of quality issues related to the geometric-mean based resource selection, zcorpan suggested to try and limit upscaling only to above 1x screens: http://ircbot.responsiveimages.org/bot/log/respimg/2015-03-31#T121926 While waiting for some research that would make it clearer in what scenarios we should upscale and in what scenarios we shouldn't, this seems like a good-enough immediate band-aid. BUG=471337 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192927

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/core/html/parser/HTMLSrcsetParser.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/parser/HTMLSrcsetParserTest.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045353002/1

5 years, 8 months ago (2015-04-01 10:04:28 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 12:51:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192927