Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: Source/modules/permissions/Permissions.idl

Issue 1045283002: Implement PermissionDescriptor usage in Permissions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: no find copies Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/permissions/Permissions.idl
diff --git a/Source/modules/permissions/Permissions.idl b/Source/modules/permissions/Permissions.idl
index 736c86efe369106c918c8865a068c0b431a7f5ed..89f7dfd085feaf198c4d532d4c1d92001f12a072 100644
--- a/Source/modules/permissions/Permissions.idl
+++ b/Source/modules/permissions/Permissions.idl
@@ -5,17 +5,10 @@
// Specification at:
// https://w3c.github.io/permissions/
-enum PermissionName {
- "geolocation",
- "notifications",
- "push-notifications",
- "midi-sysex"
-};
-
[
Exposed=(Window,Worker),
GarbageCollected,
RuntimeEnabled=Permissions
] interface Permissions {
- [CallWith=ScriptState] Promise<PermissionStatus> query(PermissionName permission);
+ [CallWith=ScriptState] Promise<PermissionStatus> query(object permission);
whywhat 2015/03/31 14:51:45 won't PermissionDescriptor work here?
mlamouri (slow - plz ping) 2015/03/31 20:24:47 Yes and no. It would be we couldn't re-parse it to
};

Powered by Google App Engine
This is Rietveld 408576698