Issue 1045113002: ES6: Unscopable should use ToBoolean

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045113002: ES6: Unscopable should use ToBoolean (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)

Modified:
5 years, 8 months ago

Reviewers:
adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

ES6: Unscopable should use ToBoolean The spec settled on ToBoolean instead of only using not undefined. BUG=v8:3827 LOG=N R=adamk Committed: https://crrev.com/bb21979adf9f86efdcb26cd674f50e55ec4527a1 Cr-Commit-Position: refs/heads/master@{#27548}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
	M	src/contexts.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mjsunit/es6/unscopables.js	View		1 chunk	+25 lines, -15 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045113002/1

5 years, 8 months ago (2015-03-31 14:32:46 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 15:14:29 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bb21979adf9f86efdcb26cd674f50e55ec4527a1
Cr-Commit-Position: refs/heads/master@{#27548}