src/contexts.cc - Issue 1045113002: ES6: Unscopable should use ToBoolean

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/contexts.cc

Issue 1045113002: ES6: Unscopable should use ToBoolean (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/contexts.cc

diff --git a/src/contexts.cc b/src/contexts.cc

index 6bd6764546702d8cf2a9de42b55435e3046b6e9f..a6a61df624a49c9460806a96fee5b166ba65efcd 100644

--- a/src/contexts.cc

+++ b/src/contexts.cc

@@ -141,7 +141,7 @@ static Maybe<PropertyAttributes> UnscopableLookup(LookupIterator* it) {

DCHECK(isolate->has_pending_exception());

return Nothing<PropertyAttributes>();

}

- return blacklist->IsUndefined() ? attrs : Just(ABSENT);

+ return blacklist->BooleanValue() ? Just(ABSENT) : attrs;

}

static void GetAttributesAndBindingFlags(VariableMode mode,

« no previous file with comments | « no previous file | test/mjsunit/es6/unscopables.js » ('j') | no next file with comments »