Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/extensions/extension_devtools_browsertests.cc

Issue 10449042: Remove wchar/wstring version of StringPrintf. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_devtools_browsertests.cc
diff --git a/chrome/browser/extensions/extension_devtools_browsertests.cc b/chrome/browser/extensions/extension_devtools_browsertests.cc
index 2c14017cca3f4643b42160d220ac5667659c88b3..f0a9a86f2fedf0b06b1de7d5a0293c66fb5d6397 100644
--- a/chrome/browser/extensions/extension_devtools_browsertests.cc
+++ b/chrome/browser/extensions/extension_devtools_browsertests.cc
@@ -4,6 +4,7 @@
#include "base/memory/ref_counted.h"
#include "base/stringprintf.h"
+#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_devtools_browsertest.h"
#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/browser/extensions/extension_host.h"
@@ -75,8 +76,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionDevToolsBrowserTest, TimelineApi) {
// Test setup.
bool result = false;
- std::wstring register_listeners_js = base::StringPrintf(
- L"setListenersOnTab(%d)", tab_id);
+ std::wstring register_listeners_js = ASCIIToWide(base::StringPrintf(
+ "setListenersOnTab(%d)", tab_id));
ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
host->render_view_host(), L"", register_listeners_js, &result));
EXPECT_TRUE(result);
@@ -134,8 +135,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionDevToolsBrowserTest, ProcessRefCounting) {
// Test setup.
bool result = false;
- std::wstring register_listeners_js = base::StringPrintf(
- L"setListenersOnTab(%d)", tab_id);
+ std::wstring register_listeners_js = ASCIIToWide(base::StringPrintf(
+ "setListenersOnTab(%d)", tab_id));
ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
host_one->render_view_host(), L"", register_listeners_js, &result));
EXPECT_TRUE(result);
@@ -147,8 +148,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionDevToolsBrowserTest, ProcessRefCounting) {
web_contents->GetRenderViewHost())));
// Register listeners from the second extension as well.
- std::wstring script = base::StringPrintf(L"registerListenersForTab(%d)",
- tab_id);
+ std::wstring script = ASCIIToWide(base::StringPrintf(
+ "registerListenersForTab(%d)", tab_id));
ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
host_two->render_view_host(), L"", script, &result));
EXPECT_TRUE(result);

Powered by Google App Engine
This is Rietveld 408576698