Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/diagnostics/diagnostics_main.cc

Issue 10449042: Remove wchar/wstring version of StringPrintf. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/diagnostics/diagnostics_main.cc
diff --git a/chrome/browser/diagnostics/diagnostics_main.cc b/chrome/browser/diagnostics/diagnostics_main.cc
index 96212e4809b9f66ad983e7ef6f810e68fc928f48..a6ae875e426f204b7293ba8a2897ea1bc0e66b92 100644
--- a/chrome/browser/diagnostics/diagnostics_main.cc
+++ b/chrome/browser/diagnostics/diagnostics_main.cc
@@ -246,13 +246,13 @@ class TestWriter {
std::wstring PrintableUSCurrentTime() {
base::Time::Exploded exploded = {0};
base::Time::Now().UTCExplode(&exploded);
- return base::StringPrintf(L"%d:%d:%d.%d:%d:%d",
- exploded.year,
- exploded.month,
- exploded.day_of_month,
- exploded.hour,
- exploded.minute,
- exploded.second);
+ return ASCIIToWide(base::StringPrintf("%d:%d:%d.%d:%d:%d",
+ exploded.year,
+ exploded.month,
+ exploded.day_of_month,
+ exploded.hour,
+ exploded.minute,
+ exploded.second));
}
// This class is a basic test controller. In this design the view (TestWriter)
@@ -282,8 +282,8 @@ class TestController : public DiagnosticsModel::Observer {
}
ResourceBundle::InitSharedInstanceWithLocale(std::string(), NULL);
int count = model->GetTestAvailableCount();
- writer_->WriteInfoText(base::StringPrintf(
- L"%d available test(s)\n\n", count));
+ writer_->WriteInfoText(ASCIIToWide(base::StringPrintf(
+ "%d available test(s)\n\n", count)));
model->RunAll(this);
}
@@ -302,8 +302,8 @@ class TestController : public DiagnosticsModel::Observer {
virtual void OnDoneAll(DiagnosticsModel* model) {
if (writer_->failures() > 0) {
- writer_->WriteInfoText(base::StringPrintf(
- L"DONE. %d failure(s)\n\n", writer_->failures()));
+ writer_->WriteInfoText(ASCIIToWide(base::StringPrintf(
+ "DONE. %d failure(s)\n\n", writer_->failures())));
} else {
writer_->WriteInfoText(L"DONE\n\n");
}

Powered by Google App Engine
This is Rietveld 408576698