Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 10449006: Compile with -Wno-unused-local-typedefs to allow compilation with GCC 4.8 (Closed)

Created:
8 years, 7 months ago by Tobias Burnus
Modified:
5 years ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Compile with -Wno-unused-local-typedefs to prevent compilation with GCC 4.8 from failing. The problem is that STATIC_CHECK internally uses a typedef which is only used as check whether a condition is compile-time evaluatable. As it is not otherwise used, GCC warns about "locally defined but not used". BUG=v8:2149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/common.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tobias Burnus
GCC 4.8 has a new check warning: -Wunused-local-typedefs. That warning is enabled by -Wall and ...
8 years, 7 months ago (2012-05-24 08:26:20 UTC) #1
Sven Panne
8 years, 7 months ago (2012-05-24 08:38:11 UTC) #2
As I mentioned in http://code.google.com/p/v8/issues/detail?id=2149, the right
fix is probably moving the STATIC_ASSERTS, not silencing the compiler.

Powered by Google App Engine
This is Rietveld 408576698