Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1044733003:
Remove uses of deprecated Header class (Closed)
|
Created:
5 years, 8 months ago by aberent Modified:
5 years, 8 months ago CC:
aurimas (slooooooooow), chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove uses of deprecated Header class
BUG=468863
Committed: https://crrev.com/4eced5f66aee2d529658677b5414b6e7116cfea9
Cr-Commit-Position: refs/heads/master@{#323024}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Move canPlayMedia to MediaUrlResolver #
Total comments: 2
Patch Set 3 : Fix nits. #Patch Set 4 : Fix findbugs problem #
Messages
Total messages: 22 (8 generated)
aberent@chromium.org changed reviewers: + avayvod@chromium.org, miguelg@chromium.org
Anton - overall review please Miguel - OWNER approval please (assuming https://codereview.chromium.org/1042803003/ doesn't land first).
https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java (right): https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java:1052: private boolean canPlayMedia(Uri uri, Map<String, List<String>> headers) { As I explain in the other comment I'd rather move this into the MediaUrlResolver. One extra reason would be that there's a method with the same name but different arguments in this class and its confusing. https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java (right): https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java:67: public Map<String, List<String>> getHeaders() { I thought you were going to turn this array into a boolean? I'd rather keep the CORS_HEADER logic here and just pass canPlayMediaRemotely boolean back to the controller if the CORS check is okay. You could move canPlayMedia(URI, Headers[]) and isEnhancedMedia() here from the controller.
https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java (right): https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java:1052: private boolean canPlayMedia(Uri uri, Map<String, List<String>> headers) { On 2015/03/30 15:51:34, whywhat wrote: > As I explain in the other comment I'd rather move this into the > MediaUrlResolver. One extra reason would be that there's a method with the same > name but different arguments in this class and its confusing. Done. https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java (right): https://codereview.chromium.org/1044733003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java:67: public Map<String, List<String>> getHeaders() { On 2015/03/30 15:51:34, whywhat wrote: > I thought you were going to turn this array into a boolean? > I'd rather keep the CORS_HEADER logic here and just pass canPlayMediaRemotely > boolean back to the controller if the CORS check is okay. You could move > canPlayMedia(URI, Headers[]) and isEnhancedMedia() here from the controller. Done.
lgtm https://codereview.chromium.org/1044733003/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java (right): https://codereview.chromium.org/1044733003/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java:186: return HLS_MEDIA; nit: these if-s are probably one liners?
https://codereview.chromium.org/1044733003/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java (right): https://codereview.chromium.org/1044733003/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java:186: return HLS_MEDIA; On 2015/03/30 at 17:34:02, whywhat wrote: > nit: these if-s are probably one liners? Done.
The CQ bit was checked by aberent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/1044733003/#ps40001 (title: "Fix nits.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044733003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2015/03/31 09:27:56, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) lgtm - see if this works, since I should now be an owner
lgtm
The CQ bit was checked by aberent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044733003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by aberent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from miguelg@chromium.org, avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/1044733003/#ps60001 (title: "Fix findbugs problem")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044733003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/4eced5f66aee2d529658677b5414b6e7116cfea9 Cr-Commit-Position: refs/heads/master@{#323024} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
