Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 104473002: Tweak TextTrackCue/VTTCue virtual functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index 706cbf87902bdc44a1376827996c78747aa2dcc3..92ac020549c298d12f8f5bae39e54ff54c27c0a5 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -81,17 +81,19 @@ public:
// FIXME: Consider refactoring to eliminate or merge the following three members.
// https://code.google.com/p/chromium/issues/detail?id=322434
- virtual void updateDisplayTree(double movieTime) { }
- virtual void removeDisplayTree() { }
- virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) { }
+ virtual void updateDisplayTree(double movieTime) = 0;
+ virtual void removeDisplayTree() = 0;
+ virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) = 0;
virtual const AtomicString& interfaceName() const OVERRIDE;
+#ifndef NDEBUG
+ virtual String toString() const = 0;
+#endif
+
DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
- virtual String toString() const;
-
protected:
TextTrackCue(double start, double end);
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698