Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: Source/core/html/track/TextTrackCue.h

Issue 104473002: Tweak TextTrackCue/VTTCue virtual functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 using EventTarget::dispatchEvent; 74 using EventTarget::dispatchEvent;
75 virtual bool dispatchEvent(PassRefPtr<Event>) OVERRIDE; 75 virtual bool dispatchEvent(PassRefPtr<Event>) OVERRIDE;
76 76
77 bool isActive(); 77 bool isActive();
78 void setIsActive(bool); 78 void setIsActive(bool);
79 79
80 virtual void updateDisplay(const IntSize& videoSize, HTMLDivElement& contain er) = 0; 80 virtual void updateDisplay(const IntSize& videoSize, HTMLDivElement& contain er) = 0;
81 81
82 // FIXME: Consider refactoring to eliminate or merge the following three mem bers. 82 // FIXME: Consider refactoring to eliminate or merge the following three mem bers.
83 // https://code.google.com/p/chromium/issues/detail?id=322434 83 // https://code.google.com/p/chromium/issues/detail?id=322434
84 virtual void updateDisplayTree(double movieTime) { } 84 virtual void updateDisplayTree(double movieTime) = 0;
85 virtual void removeDisplayTree() { } 85 virtual void removeDisplayTree() = 0;
86 virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) { } 86 virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) = 0;
87 87
88 virtual const AtomicString& interfaceName() const OVERRIDE; 88 virtual const AtomicString& interfaceName() const OVERRIDE;
89 89
90 #ifndef NDEBUG
91 virtual String toString() const = 0;
92 #endif
93
90 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter); 94 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
91 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit); 95 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
92 96
93 virtual String toString() const;
94
95 protected: 97 protected:
96 TextTrackCue(double start, double end); 98 TextTrackCue(double start, double end);
97 99
98 void cueWillChange(); 100 void cueWillChange();
99 virtual void cueDidChange(); 101 virtual void cueDidChange();
100 102
101 private: 103 private:
102 String m_id; 104 String m_id;
103 double m_startTime; 105 double m_startTime;
104 double m_endTime; 106 double m_endTime;
105 int m_cueIndex; 107 int m_cueIndex;
106 108
107 TextTrack* m_track; 109 TextTrack* m_track;
108 110
109 bool m_isActive; 111 bool m_isActive;
110 bool m_pauseOnExit; 112 bool m_pauseOnExit;
111 }; 113 };
112 114
113 } // namespace WebCore 115 } // namespace WebCore
114 116
115 #endif 117 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698