Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1044593002: Revert of range.getBoundingClientRect() returns incorrect value for collapsed ranges (Closed)

Created:
5 years, 9 months ago by Peter Kasting
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of range.getBoundingClientRect() returns incorrect value for collapsed ranges (patchset #3 id:40001 of https://codereview.chromium.org/998263002/) Reason for revert: Seems to have broken CvoxShadowUnitTest.MultilineWrap in the chromevox_tests. Original issue's description: > range.getBoundingClientRect() returns incorrect value for collapsed ranges > > Current implementation returns empty rectangle if > either width or height is zero. But as per W3C specification [1], > getBoundingClientRect() should return union of rectangles > of which the height or width is not zero. > > [1] http://www.w3.org/TR/cssom-view/#dom-range-getclientrects > > BUG=435438 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192699 TBR=keishi@chromium.org,vivekg@chromium.org,eae@chromium.org,kandalkar.abhijeet58@gmail.com,abhijeet.k@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=435438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -61 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/Range/getBoundingClientRect-caret.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/dom/Range/getBoundingClientRect-caret-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Peter Kasting
Created Revert of range.getBoundingClientRect() returns incorrect value for collapsed ranges
5 years, 9 months ago (2015-03-28 03:00:33 UTC) #1
Peter Kasting
More detail: Flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chromevox_tests&showExpectations=true&tests=CvoxShadowUnitTest.MultilineWrap This implicates http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=192698:192700&mode=html or https://chromium.googlesource.com/chromium/src/+/14bab52bbe1d8bf33034300f741d44cfacb27d06 . The most likely ...
5 years, 9 months ago (2015-03-28 03:05:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044593002/1
5 years, 9 months ago (2015-03-28 03:05:32 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 9 months ago (2015-03-28 03:05:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044593002/1
5 years, 9 months ago (2015-03-28 03:12:24 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 03:12:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192714

Powered by Google App Engine
This is Rietveld 408576698