Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1044483002: cleanup hints (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

cleanup hints Discarded in favor of https://codereview.chromium.org/1042913002/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/namespace.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-03-27 21:15:39 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-27 21:21:55 UTC) #3
Paul Berry
5 years, 8 months ago (2015-03-27 21:34:04 UTC) #4
(Capturing the conclusion of an IM discussion between me and Dan)

We're not going to land this yet.  First we want to push out a new (-dev)
version of analyzer that supports ".operator", and then update analysis_server's
pubspec as part of this CL, so that anyone who is trying to run analysis server
using its pubspec won't be broken by the change.

I will take care of doing that on Monday (or earlier if time allows).

Powered by Google App Engine
This is Rietveld 408576698