Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/IceTargetLoweringARM32.cpp

Issue 1044423006: WIP: Add ARM32 add/ldr/str instructions and operand types. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringARM32.h ('k') | tests_lit/llvm2ice_tests/arith-opt.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.cpp
diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp
index d65b5469c18c7f6b175b9a916c9474ec7bc37e6b..25c6f2bd90c0a4a5b5173dcbf52ae3c0be27a7ad 100644
--- a/src/IceTargetLoweringARM32.cpp
+++ b/src/IceTargetLoweringARM32.cpp
@@ -542,8 +542,6 @@ void TargetARM32::lowerArithmetic(const InstArithmetic *Inst) {
// E.g., use BIC (bit clear) instead of AND for some masks.
Variable *Src0 = legalizeToVar(Inst->getSrc(0));
Operand *Src1 = legalize(Inst->getSrc(1), Legal_Reg | Legal_Flex);
- (void)Src0;
- (void)Src1;
if (Dest->getType() == IceType_i64) {
UnimplementedError(Func->getContext()->getFlags());
} else if (isVectorType(Dest->getType())) {
@@ -554,10 +552,9 @@ void TargetARM32::lowerArithmetic(const InstArithmetic *Inst) {
llvm_unreachable("Unknown arithmetic operator");
break;
case InstArithmetic::Add: {
- UnimplementedError(Func->getContext()->getFlags());
- // Variable *T = makeReg(Dest->getType());
- // _add(T, Src0, Src1);
- // _mov(Dest, T);
+ Variable *T = makeReg(Dest->getType());
+ _add(T, Src0, Src1);
+ _mov(Dest, T);
} break;
case InstArithmetic::And:
UnimplementedError(Func->getContext()->getFlags());
« no previous file with comments | « src/IceTargetLoweringARM32.h ('k') | tests_lit/llvm2ice_tests/arith-opt.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698