Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 104433005: SkOnce: let f be any functor, update comments (Closed)

Created:
7 years ago by mtklein
Modified:
7 years ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SkOnce: let f be any functor, update comments BUG= Committed: http://code.google.com/p/skia/source/detail?r=12518

Patch Set 1 #

Patch Set 2 : Remove power API, leave some nice tweaks instead. #

Patch Set 3 : tests SkOnceFlag was uninitialized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M src/core/SkOnce.h View 1 2 4 chunks +20 lines, -20 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/OnceTest.cpp View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
Think you can use this for SkPixelRef::getImageInfo?
7 years ago (2013-12-04 19:50:51 UTC) #1
mtklein
Looks like we won't need the power user API just yet. Here are some little ...
7 years ago (2013-12-05 15:50:24 UTC) #2
mtklein
On 2013/12/05 15:50:24, mtklein wrote: > Looks like we won't need the power user API ...
7 years ago (2013-12-05 16:18:23 UTC) #3
bungeman-skia
lgtm, though the difference between the static macro and not having a macro for non-static ...
7 years ago (2013-12-05 16:36:28 UTC) #4
mtklein
On 2013/12/05 16:36:28, bungeman1 wrote: > lgtm, though the difference between the static macro and ...
7 years ago (2013-12-05 18:43:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/104433005/40001
7 years ago (2013-12-05 18:44:32 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-05 19:20:53 UTC) #7
Message was sent while issue was closed.
Change committed as 12518

Powered by Google App Engine
This is Rietveld 408576698