Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1044323002:
Add manage.py --remaining to count remaining tests to convert to Swarming. (Closed)
|
Created:
5 years, 8 months ago by M-A Ruel Modified:
5 years, 8 months ago Reviewers:
Paweł Hajdan Jr. CC:
chromium-reviews, jam, jochen (gone - plz use gerrit), scottmg Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_convert_json Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd manage.py --remaining to count remaining tests to convert to Swarming.
R=phajdan.jr@chromium.org
BUG=98637
Committed: https://crrev.com/1ed439f01a1a442f0cc74e799192f4ee03ea8a28
Cr-Commit-Position: refs/heads/master@{#323235}
Patch Set 1 : . #
Total comments: 2
Patch Set 2 : Use a dict #Patch Set 3 : Update colorama path, looks like a local install was caught locally #
Total comments: 1
Messages
Total messages: 15 (5 generated)
Patchset #1 (id:1) has been deleted
This CL is based on https://codereview.chromium.org/1049703005. It adds analysis functionality to the script. I think there's a lot of low hanging fruits in there, especially the ones that are partially run on Swarming. Sample outputs: $ ./manage.py --remaining Test Local Swarming accessibility_unittests 23 7 app_installer_unittests 2 0 app_list_unittests 17 7 app_shell_unittests 19 0 ash_unittests 2 8 aura_unittests 23 0 base_unittests 12 31 blink_heap_unittests 21 0 blink_platform_unittests 21 0 browser_tests 11 31 cacheinvalidation_unittests 41 0 cast_media_unittests 1 0 cast_shell_browser_test 1 0 cast_unittests 12 12 cc_unittests 12 12 chrome_elf_unittests 14 0 chromedriver_unittests 23 0 chromeos_unittests 6 0 chromevox_tests 3 0 components_browsertests 2 3 components_unittests 29 12 compositor_unittests 21 0 content_browsertests 12 33 content_unittests 18 28 courgette_unittests 0 14 crypto_unittests 11 31 dbus_unittests 16 0 device_unittests 31 0 display_unittests 20 0 events_unittests 20 3 extensions_browsertests 4 13 extensions_unittests 38 0 gcm_unit_tests 40 0 gfx_unittests 19 7 gn_unittests 4 0 google_apis_unittests 38 0 gpu_unittests 29 12 installer_util_unittests 14 0 interactive_ui_tests 6 25 ipc_mojo_unittests 8 0 ipc_tests 42 0 jingle_unittests 41 0 keyboard_unittests 2 0 media_unittests 29 12 message_center_unittests 9 4 mojo_common_unittests 21 0 mojo_public_bindings_unittests 20 0 mojo_public_environment_unittests 20 0 mojo_public_system_unittests 20 0 mojo_public_utility_unittests 20 0 mojo_system_unittests 20 0 nacl_loader_unittests 26 0 net_unittests 12 29 ozone_unittests 1 0 ppapi_unittests 40 0 printing_unittests 40 0 remoting_unittests 40 0 sandbox_linux_unittests 21 0 sandbox_mac_unittests 5 0 sbox_integration_tests 14 0 sbox_unittests 14 0 sbox_validation_tests 14 0 skia_unittests 40 0 sql_unittests 42 0 sync_integration_tests 1 12 sync_unit_tests 42 0 ui_base_unittests 35 7 ui_chromeos_unittests 4 0 ui_touch_selection_unittests 19 3 unit_tests 14 28 url_unittests 41 0 views_unittests 32 0 webkit_unit_tests 21 0 wm_unittests 22 0 wtf_unittests 21 0 Total: 1449 (79.1%) 384 (20.9%) Total executions: 1833 $ ./manage.py --remaining net_unittests chromium.fyi.json: Cast Linux Chromium Mac 10.10 ClangToTLinux tester CrWinAsan tester CrWinAsan(dll) tester CrWinClangLLD tester Linux Trusty Linux Trusty (32) Linux Trusty (dbg) Linux Trusty (dbg)(32) chromium.memory.fyi.json: Linux ChromeOS MSan Tests Linux MSan Tests
https://codereview.chromium.org/1044323002/diff/20001/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1044323002/diff/20001/testing/buildbot/manage... testing/buildbot/manage.py:59: tests_location = collections.defaultdict(lambda: [0, 0, {}]) This tuple makes code readability confusing. Could you use at least a dict with descriptive keys?
https://codereview.chromium.org/1044323002/diff/20001/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1044323002/diff/20001/testing/buildbot/manage... testing/buildbot/manage.py:59: tests_location = collections.defaultdict(lambda: [0, 0, {}]) On 2015/04/01 10:08:28, Paweł Hajdan Jr. wrote: > This tuple makes code readability confusing. Could you use at least a dict with > descriptive keys? Agreed, switched to a dict.
LGTM
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044323002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
https://codereview.chromium.org/1044323002/diff/60001/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1044323002/diff/60001/testing/buildbot/manage... testing/buildbot/manage.py:22: 0, os.path.join(THIS_DIR, '..', '..', 'third_party', 'colorama', 'src')) I hadn't realized there was a src directory underneath. I assume a local install was being used instead, that's why it didn't fail locally.
The CQ bit was checked by maruel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/1044323002/#ps60001 (title: "Update colorama path, looks like a local install was caught locally")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044323002/60001
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1ed439f01a1a442f0cc74e799192f4ee03ea8a28 Cr-Commit-Position: refs/heads/master@{#323235} |
