Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1049703005: Add tool to reformat testing/buildbot/ json files in their canonical format. (Closed)

Created:
5 years, 8 months ago by M-A Ruel
Modified:
5 years, 6 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tool to reformat testing/buildbot/ json files in their canonical format. The tool is now run as presubmit check. It enforces key sorting and upgrades gtest_tests to the dict format. No functional change. R=phajdan.jr@chromium.org BUG=98637 Committed: https://crrev.com/74e1ca70ce4878892b74f0c2ca8981d826e785ac Cr-Commit-Position: refs/heads/master@{#323217}

Patch Set 1 : . #

Patch Set 2 : Rename tool, as it'll be expanded #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6038 lines, -2934 lines) Patch
A + testing/buildbot/PRESUBMIT.py View 1 2 chunks +5 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.chrome.json View 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 chunk +410 lines, -190 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +2113 lines, -949 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +525 lines, -281 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +418 lines, -242 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +359 lines, -177 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 chunk +427 lines, -170 lines 0 comments Download
M testing/buildbot/chromium.perf.json View 1 chunk +103 lines, -63 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 20 chunks +606 lines, -305 lines 0 comments Download
M testing/buildbot/chromium.win.json View 6 chunks +777 lines, -391 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +34 lines, -30 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 3 chunks +171 lines, -115 lines 0 comments Download
A testing/buildbot/manage.py View 1 1 chunk +80 lines, -0 lines 1 comment Download
M testing/buildbot/trybot_analyze_config.json View 2 chunks +5 lines, -5 lines 0 comments Download
M testing/buildbot/tryserver.chromium.linux.json View 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/tryserver.chromium.mac.json View 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/tryserver.chromium.perf.json View 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/tryserver.chromium.win.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
M-A Ruel
This is towards running all tests on Swarming. I figured out that the fact that ...
5 years, 8 months ago (2015-03-31 18:13:59 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 8 months ago (2015-04-01 10:11:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049703005/40001
5 years, 8 months ago (2015-04-01 12:27:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-01 12:32:11 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/74e1ca70ce4878892b74f0c2ca8981d826e785ac Cr-Commit-Position: refs/heads/master@{#323217}
5 years, 8 months ago (2015-04-01 12:33:06 UTC) #7
Nico
https://codereview.chromium.org/1049703005/diff/40001/testing/buildbot/manage.py File testing/buildbot/manage.py (right): https://codereview.chromium.org/1049703005/diff/40001/testing/buildbot/manage.py#newcode75 testing/buildbot/manage.py:75: print('%s is not in canonical format' % filename) This ...
5 years, 6 months ago (2015-05-29 04:38:09 UTC) #9
Nico
5 years, 6 months ago (2015-05-29 04:43:25 UTC) #10
Message was sent while issue was closed.
fix attempt: https://codereview.chromium.org/1162063002/

On Thu, May 28, 2015 at 9:38 PM, <thakis@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1049703005/diff/40001/testing/buildbot/manage.py
> File testing/buildbot/manage.py (right):
>
>
>
https://codereview.chromium.org/1049703005/diff/40001/testing/buildbot/manage...
> testing/buildbot/manage.py:75: print('%s is not in canonical format' %
> filename)
> This is a pretty useless output. Maybe it could print the command to run
> to get canonical format, or at least link to some page that explains
> what the canonical format is? I just got this output and I have no idea
> what to do.
>
> https://codereview.chromium.org/1049703005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698