Chromium Code Reviews
Help | Chromium Project | Sign in
(16)

Issue 10443053: [cros] Change how login-prompt-visible signal is emitted when accelerated compositing is enabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by Nikita
Modified:
2 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[cros] Change how login-prompt-visible signal is emitted when accelerated compositing is enabled. We could not rely on NOTIFICATION_RENDER_WIDGET_HOST_DID_PAINT as it is not sent after page is loaded (even though we're updating content through JS) in case of accelerated compositing is enabled. BUG=127517 TEST=Add --allow-webui-compositing flag, check that /tmp/uptime-login-prompt-visible is still generated.

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -12 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 4 chunks +37 lines, -12 lines 2 comments Download
Commit: CQ not working?

Messages

Total messages: 8 (0 generated)
Nikita
Daniel, please take a look. Reason for this change (also described in comments): When accelerated ...
2 years, 11 months ago (2012-05-28 12:30:44 UTC) #1
Daniel Erat (OOO 5-14 to 5-22)
I'm surprised that OnTabMainFrameRender() doesn't get called again after the page's JS tells us that ...
2 years, 11 months ago (2012-05-28 15:20:53 UTC) #2
Nikita
http://codereview.chromium.org/10443053/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/10443053/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc#newcode356 chrome/browser/chromeos/login/webui_login_view.cc:356: return command_line.HasSwitch(switches::kAllowWebUICompositing); On 2012/05/28 15:20:53, Daniel Erat wrote: > ...
2 years, 11 months ago (2012-05-28 15:55:04 UTC) #3
Nikita
On 2012/05/28 15:20:53, Daniel Erat wrote: > I'm surprised that OnTabMainFrameRender() doesn't get called again ...
2 years, 11 months ago (2012-05-28 16:02:18 UTC) #4
jonathan.backer
On 2012/05/28 16:02:18, Nikita Kostylev wrote: > On 2012/05/28 15:20:53, Daniel Erat wrote: > > ...
2 years, 11 months ago (2012-05-28 16:50:43 UTC) #5
jonathan.backer
On 2012/05/28 16:50:43, jonathan.backer wrote: > On 2012/05/28 16:02:18, Nikita Kostylev wrote: > > On ...
2 years, 11 months ago (2012-05-28 18:09:29 UTC) #6
jonathan.backer
On 2012/05/28 18:09:29, jonathan.backer wrote: > On 2012/05/28 16:50:43, jonathan.backer wrote: > > On 2012/05/28 ...
2 years, 11 months ago (2012-05-28 18:39:46 UTC) #7
Nikita
2 years, 11 months ago (2012-06-01 19:04:49 UTC) #8
I'm abandoning this CL, there's a proper one
http://codereview.chromium.org/10476002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be