Chromium Code Reviews
Help | Chromium Project | Sign in
(400)

Issue 10443053: [cros] Change how login-prompt-visible signal is emitted when accelerated compositing is enabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by Nikita Kostylev
Modified:
1 year, 10 months ago
CC:
chromium-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[cros] Change how login-prompt-visible signal is emitted when accelerated compositing is enabled.

We could not rely on NOTIFICATION_RENDER_WIDGET_HOST_DID_PAINT as it is not sent after page is loaded (even though we're updating content through JS) in case of accelerated compositing is enabled.

BUG=127517
TEST=Add --allow-webui-compositing flag, check that /tmp/uptime-login-prompt-visible is still generated.

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -12 lines) Lint Patch
M chrome/browser/chromeos/login/webui_login_view.h View 2 chunks +13 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 4 chunks +37 lines, -12 lines 2 comments ? errors Download
Commit:

Messages

Total messages: 8
Nikita Kostylev
Daniel, please take a look. Reason for this change (also described in comments): When accelerated ...
1 year, 10 months ago #1
Daniel Erat
I'm surprised that OnTabMainFrameRender() doesn't get called again after the page's JS tells us that ...
1 year, 10 months ago #2
Nikita Kostylev
http://codereview.chromium.org/10443053/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/10443053/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc#newcode356 chrome/browser/chromeos/login/webui_login_view.cc:356: return command_line.HasSwitch(switches::kAllowWebUICompositing); On 2012/05/28 15:20:53, Daniel Erat wrote: > ...
1 year, 10 months ago #3
Nikita Kostylev
On 2012/05/28 15:20:53, Daniel Erat wrote: > I'm surprised that OnTabMainFrameRender() doesn't get called again ...
1 year, 10 months ago #4
jonathan.backer
On 2012/05/28 16:02:18, Nikita Kostylev wrote: > On 2012/05/28 15:20:53, Daniel Erat wrote: > > ...
1 year, 10 months ago #5
jonathan.backer
On 2012/05/28 16:50:43, jonathan.backer wrote: > On 2012/05/28 16:02:18, Nikita Kostylev wrote: > > On ...
1 year, 10 months ago #6
jonathan.backer
On 2012/05/28 18:09:29, jonathan.backer wrote: > On 2012/05/28 16:50:43, jonathan.backer wrote: > > On 2012/05/28 ...
1 year, 10 months ago #7
Nikita Kostylev
1 year, 10 months ago #8
I'm abandoning this CL, there's a proper one
http://codereview.chromium.org/10476002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6