Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1044193003: Fix cr SKPs naming (Closed)

Created:
5 years, 8 months ago by rmistry
Modified:
5 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix cr SKPs naming #crskps BUG=skia: BUG=skia:3574 NOTRY=true TBR=borenet Committed: https://skia.googlesource.com/skia/+/39383a194622a917dd2ae0c4b43e9c634d61e94a

Patch Set 1 : Initial upload #

Patch Set 2 : Fix #

Patch Set 3 : Add NOTRY to Hashtags #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M HASHTAGS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/webpages_playback.py View 1 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
rmistry
5 years, 8 months ago (2015-03-31 15:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044193003/60001
5 years, 8 months ago (2015-03-31 15:02:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://skia.googlesource.com/skia/+/39383a194622a917dd2ae0c4b43e9c634d61e94a
5 years, 8 months ago (2015-03-31 15:03:07 UTC) #6
borenet
5 years, 8 months ago (2015-03-31 15:29:53 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1044193003/diff/60001/tools/skp/webpages_play...
File tools/skp/webpages_playback.py (right):

https://codereview.chromium.org/1044193003/diff/60001/tools/skp/webpages_play...
tools/skp/webpages_playback.py:392: webpage = webpage[7:]
I prefer something like this:

prefix = 'http___'
if webpage.startswith(prefix):
  webpage = webpage[len(prefix):]

Or even:

for prefix in ('http___', 'https___'):
  if webpage.startswith(prefix):
    webpage = webpage[len(prefix):]

Powered by Google App Engine
This is Rietveld 408576698