Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: tools/skp/webpages_playback.py

Issue 1044193003: Fix cr SKPs naming (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Add NOTRY to Hashtags Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « HASHTAGS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skp/webpages_playback.py
diff --git a/tools/skp/webpages_playback.py b/tools/skp/webpages_playback.py
index 67c84ae38ba672e04b67c1f921215808d5ddda19..7fbb372fd39c6a69373a90b9520ec869cef6bd9a 100644
--- a/tools/skp/webpages_playback.py
+++ b/tools/skp/webpages_playback.py
@@ -388,7 +388,10 @@ class SkPicturePlayback(object):
# /path/to/http___mobile_news_sandbox_pt0 -> http___mobile_news_sandbox_pt0
_, webpage = os.path.split(site)
# http___mobile_news_sandbox_pt0 -> mobile_news_sandbox_pt0
- webpage = webpage.lstrip('http___').lstrip('https___')
+ if webpage.startswith('http___'):
+ webpage = webpage[7:]
borenet 2015/03/31 15:29:53 I prefer something like this: prefix = 'http___'
+ elif webpage.startswith('https___'):
+ webpage = webpage[8:]
# /path/to/skia_yahooanswers_desktop.py -> skia_yahooanswers_desktop.py
ps_filename = os.path.basename(page_set)
# http___mobile_news_sandbox -> pagesetprefix_http___mobile_news_sandbox
« no previous file with comments | « HASHTAGS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698