Remove most android_webview_build conditions from build.

Remove most android_webview_build conditions from build.

Remove most references to android_webview_build from the build directory
now that we no longer support that build configuration. Fold conditions
into their parents where appropriate. Leave the variable itself defined
to 0 as not all uses in the tree have been removed yet.

A few references are left alone here and will be removed separately in
later changes that will be larger refactorings to eliminate other
variables.

BUG=440793
Committed: https://crrev.com/c6fe7a775af41cd98533e89a902b8b67044caa87
Cr-Commit-Position: refs/heads/master@{#323013}

[Torne, 2015-03-30 14:22:11]

torne@chromium.org changed reviewers:
+ thakis@chromium.org

[Torne, 2015-03-30 14:22:11]

Hi Nico, here's one of the big android_webview_build purges. Would you mind
taking a look at it since you're a build owner? Everything should be no-op
changes for the case where android_webview_build==0 if I've done it right..

I've left a few android_webview_builds behind here because they're places where
there are other config variables which exist only for webview's sake; I'll
remove them separately in CLs that refactor the variables away entirely (and
send those to the owners of the features/etc in question).

[Nico, 2015-03-30 17:55:46]

lgtm with comments addressed

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi#oldcode2095
build/common.gypi:2095: 'grit_defines': ['-D', 'is_android_webview_build'],
You need to delete this conditional too:
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi#newcode4691
build/common.gypi:4691: # don't use '-isystem' because the
arm-linux-androideabi-4.4.3
hm, this comment should probably be updated, given that we do use -isystem

https://codereview.chromium.org/1043913002/diff/1/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1043913002/diff/1/build/config/features.gni#n...
build/config/features.gni:70: enable_autofill_dialog = !is_ios
should the gyp file say OS!="ios" too? should be the same, and seems easier to
understand.

[Torne, 2015-03-31 10:51:57]

The CQ bit was checked by torne@chromium.org

[Torne, 2015-03-31 10:51:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1043913002/#ps20001
(title: "Address comments and rebase")

[commit-bot: I haz the power, 2015-03-31 10:52:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1043913002/20001

[commit-bot: I haz the power, 2015-03-31 11:50:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-31 11:51:44]

Patchset 2 (id:??) landed as
https://crrev.com/c6fe7a775af41cd98533e89a902b8b67044caa87
Cr-Commit-Position: refs/heads/master@{#323013}

[Torne, 2015-03-31 13:50:02]

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi#oldcode2095
build/common.gypi:2095: 'grit_defines': ['-D', 'is_android_webview_build'],
On 2015/03/30 17:55:46, Nico wrote:
> You need to delete this conditional too:
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...

Already being removed in my components change:
https://codereview.chromium.org/1041673002/

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi#newcode4691
build/common.gypi:4691: # don't use '-isystem' because the
arm-linux-androideabi-4.4.3
On 2015/03/30 17:55:46, Nico wrote:
> hm, this comment should probably be updated, given that we do use -isystem

Removed the obsolete part of this comment.

https://codereview.chromium.org/1043913002/diff/1/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1043913002/diff/1/build/config/features.gni#n...
build/config/features.gni:70: enable_autofill_dialog = !is_ios
On 2015/03/30 17:55:46, Nico wrote:
> should the gyp file say OS!="ios" too? should be the same, and seems easier to
> understand.

Done.

[Nico, 2015-03-31 15:28:03]

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi#oldcode2095
build/common.gypi:2095: 'grit_defines': ['-D', 'is_android_webview_build'],
On 2015/03/31 13:50:02, Torne wrote:
> On 2015/03/30 17:55:46, Nico wrote:
> > You need to delete this conditional too:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...
> 
> Already being removed in my components change:
> https://codereview.chromium.org/1041673002/

That's not good enough. This CL here removes the is_android_webview_build grit
define, so now dom_distiller_resources.grdp incorrectly won't be included while
this Cl is in the tree but the one you linked to isn't yet. Please revert this
part quickly, and reland it only after your other CL is in.

[Nico, 2015-03-31 15:33:29]

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/1043913002/diff/1/build/common.gypi#oldcode2095
build/common.gypi:2095: 'grit_defines': ['-D', 'is_android_webview_build'],
On 2015/03/31 15:28:03, Nico wrote:
> On 2015/03/31 13:50:02, Torne wrote:
> > On 2015/03/30 17:55:46, Nico wrote:
> > > You need to delete this conditional too:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...
> > 
> > Already being removed in my components change:
> > https://codereview.chromium.org/1041673002/
> 
> That's not good enough. This CL here removes the is_android_webview_build grit
> define, so now dom_distiller_resources.grdp incorrectly won't be included
while
> this Cl is in the tree but the one you linked to isn't yet. Please revert this
> part quickly, and reland it only after your other CL is in.

You're right, the grd file checks "if this isn't set", so not setting it
shouldn't change anything. Sorry for the noise.