build/module_args/v8.gni - Issue 1043913002: Remove most android_webview_build conditions from build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/module_args/v8.gni

Issue 1043913002: Remove most android_webview_build conditions from build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/module_args/v8.gni

diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni

index df6a4a3ccebfe5a0204b89111e359c0725e9123a..db4ee4e97a3bbdc9cd861d6d979398b296d0c7ee 100644

--- a/build/module_args/v8.gni

+++ b/build/module_args/v8.gni

@@ -9,5 +9,4 @@ if (is_android) {

# TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.

enable_correct_v8_arch = false

-v8_use_external_startup_data =

- !((is_android && is_android_webview_build) || is_chromeos || is_win)

+v8_use_external_startup_data = !(is_chromeos || is_win)

« no previous file with comments | « build/jni_generator.gypi ('k') | no next file » | no next file with comments »