Disable Cloudbackup for RTL languages in M42, as it is not sufficiently well layed out.

Disable Cloudbackup for RTL languages in M42, as it is not sufficiently well layed out.

BUG=471628
TEST=Manual

Committed: https://crrev.com/ba65256d65b09efd669995fbbb04c6552f486164
Cr-Commit-Position: refs/heads/master@{#322965}

[Steve McKay, 2015-03-30 05:42:48]

smckay@chromium.org changed reviewers:
+ bengold@chromium.org, fukino@chromium.org

[Steve McKay, 2015-03-30 05:42:48]

Sadness, but way better than leaving things in the sad shape they are for RTL
langs. To be reverted once patched into M42.

[fukino, 2015-03-30 05:51:56]

lgtm with a nit for the code. Let's wait bengold@'s voice.

https://codereview.chromium.org/1043793004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/1043793004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/common/js/importer_common.js:281: resolve(!disabled
&& !document.querySelector('html[dir=rtl]'));
nit: html[dir="rtl"] might be better.

[Steve McKay, 2015-03-30 06:59:18]

Respond to review comments.

[Steve McKay, 2015-03-30 08:07:48]

Update to use explicit list of languages in RTL check.

[Steve McKay, 2015-03-30 08:08:57]

Please take another look. Hit commit check if you're happy.

https://codereview.chromium.org/1043793004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/1043793004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/common/js/importer_common.js:281: resolve(!disabled
&& !document.querySelector('html[dir=rtl]'));
On 2015/03/30 05:51:56, fukino wrote:
> nit: html[dir="rtl"] might be better. 

Had to update to check languages explicitly. Document for background page
doesn't have "dir" attribute.

[fukino, 2015-03-30 08:31:28]

https://codereview.chromium.org/1043793004/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/1043793004/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:281: var rtl = ['ar',
'iw', 'he'].indexOf(
I think Persian (fa) should also be included.

[Steve McKay, 2015-03-30 09:10:11]

Respond to review comments.

[Steve McKay, 2015-03-30 09:10:34]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-03-30 09:10:35]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/1043793004/#ps60001
(title: "Respond to review comments.")

[commit-bot: I haz the power, 2015-03-30 09:10:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1043793004/60001

[Steve McKay, 2015-03-30 09:11:43]

Thanks!

https://codereview.chromium.org/1043793004/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/1043793004/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:281: var rtl = ['ar',
'iw', 'he'].indexOf(
On 2015/03/30 08:31:28, fukino wrote:
> I think Persian (fa) should also be included.

Done.

[fukino, 2015-03-30 09:12:08]

On 2015/03/30 09:11:43, Steve McKay wrote:
> Thanks!
> 
>
https://codereview.chromium.org/1043793004/diff/40001/ui/file_manager/file_ma...
> File ui/file_manager/file_manager/common/js/importer_common.js (right):
> 
>
https://codereview.chromium.org/1043793004/diff/40001/ui/file_manager/file_ma...
> ui/file_manager/file_manager/common/js/importer_common.js:281: var rtl =
['ar',
> 'iw', 'he'].indexOf(
> On 2015/03/30 08:31:28, fukino wrote:
> > I think Persian (fa) should also be included.
> 
> Done.

lgtm, thanks!

[commit-bot: I haz the power, 2015-03-30 10:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-30 10:48:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Steve McKay, 2015-03-31 02:11:29]

Stub out chrome.i18n for device handler test.

[Steve McKay, 2015-03-31 02:11:33]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-03-31 02:11:33]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/1043793004/#ps80001
(title: "Stub out chrome.i18n for device handler test.")

[commit-bot: I haz the power, 2015-03-31 02:12:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1043793004/80001

[commit-bot: I haz the power, 2015-03-31 02:50:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-31 02:51:20]

Patchset 5 (id:??) landed as
https://crrev.com/ba65256d65b09efd669995fbbb04c6552f486164
Cr-Commit-Position: refs/heads/master@{#322965}