Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3361)

Unified Diff: ui/file_manager/file_manager/common/js/importer_common.js

Issue 1043793004: Disable Cloudbackup for RTL languages in M42, as it is not sufficiently well layed out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Stub out chrome.i18n for device handler test. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/background/js/device_handler_unittest.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/common/js/importer_common.js
diff --git a/ui/file_manager/file_manager/common/js/importer_common.js b/ui/file_manager/file_manager/common/js/importer_common.js
index 47e300c417dbe9d58bfe176f2904e287e3528dda..8a441f8ce6a6e83bbb2fa30cc6cd38ea32b97e65 100644
--- a/ui/file_manager/file_manager/common/js/importer_common.js
+++ b/ui/file_manager/file_manager/common/js/importer_common.js
@@ -276,7 +276,11 @@ importer.importEnabled = function() {
'disable-cloud-import',
/** @param {boolean} disabled */
function(disabled) {
- resolve(!disabled);
+ // TODO(smckay): For M42 only, we dropped the ball on
+ // decent RTL formatting. Disable it for the duration of M42 only.
+ var rtl = ['ar', 'iw', 'he', 'fa'].indexOf(
+ chrome.i18n.getUILanguage().toLowerCase()) !== -1;
+ resolve(!disabled && !rtl);
});
});
};
« no previous file with comments | « ui/file_manager/file_manager/background/js/device_handler_unittest.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698