Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1043723002: Handle NewExpression in SemanticSendVisitor. (Closed)

Created:
5 years, 9 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, Anders Johnsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Handle NewExpression in SemanticSendVisitor. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44800

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Rebased+fix modely.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1343 lines, -193 lines) Patch
M pkg/analyzer2dart/lib/src/modely.dart View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 3 chunks +13 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 3 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 2 chunks +122 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 9 chunks +50 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 3 chunks +179 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 12 chunks +284 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +63 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 2 chunks +67 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 42 chunks +538 lines, -118 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 9 months ago (2015-03-28 17:53:01 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1043723002/diff/20001/pkg/compiler/lib/src/resolution/access_semantics.dart File pkg/compiler/lib/src/resolution/access_semantics.dart (right): https://codereview.chromium.org/1043723002/diff/20001/pkg/compiler/lib/src/resolution/access_semantics.dart#newcode323 pkg/compiler/lib/src/resolution/access_semantics.dart:323: GENERATIVE, fyi. This seems to be under discussion, ...
5 years, 8 months ago (2015-03-30 17:17:24 UTC) #3
Johnni Winther
https://codereview.chromium.org/1043723002/diff/20001/pkg/compiler/lib/src/resolution/access_semantics.dart File pkg/compiler/lib/src/resolution/access_semantics.dart (right): https://codereview.chromium.org/1043723002/diff/20001/pkg/compiler/lib/src/resolution/access_semantics.dart#newcode323 pkg/compiler/lib/src/resolution/access_semantics.dart:323: GENERATIVE, On 2015/03/30 17:17:24, floitsch wrote: > fyi. > ...
5 years, 8 months ago (2015-03-31 09:51:14 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-03-31 10:03:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 44800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698