Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1043283003: [Effen] s/Node/UINode/, s/Element/WrapperNode/, s/EventTarget/EventListenerNode/ (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] s/Node/UINode/, s/Element/WrapperNode/, s/EventTarget/EventListenerNode/ R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3ee2c8eb931285ef58af13aac208dd4bfeda9a5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -135 lines) Patch
M sky/examples/hello_world/hello_world.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks/lib/stock_app.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M sky/examples/stocks/lib/stock_arrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks/lib/stock_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks/lib/stock_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks/lib/stock_row.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/widgets/widgets_app.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/README.md View 6 chunks +9 lines, -9 lines 0 comments Download
M sky/framework/components/action_bar.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/framework/components/button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/button_base.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/checkbox.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/drawer.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/framework/components/drawer_header.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/floating_action_button.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/icon.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/icon_button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/ink_well.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/framework/components/input.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/material.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/menu_item.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/modal_overlay.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/components/popup_menu.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/components/popup_menu_item.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/radio.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/components/scaffold.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/framework/components/scrollable.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/editing/editable_text.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/fn.dart View 27 chunks +55 lines, -55 lines 0 comments Download
M sky/sdk/README.md View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
I'm not sure entirely what this gets us, other than giving us the post-fix "Node" ...
5 years, 8 months ago (2015-03-31 22:43:44 UTC) #2
Hixie
5 years, 8 months ago (2015-04-01 16:46:32 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3ee2c8eb931285ef58af13aac208dd4bfeda9a5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698