Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: components/storage_monitor/storage_monitor_chromeos.cc

Issue 1043013002: favor DCHECK_CURRENTLY_ON for better logs in components/ (part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master + add one more Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/storage_monitor/storage_monitor_chromeos.cc
diff --git a/components/storage_monitor/storage_monitor_chromeos.cc b/components/storage_monitor/storage_monitor_chromeos.cc
index 92e7cfd576938300cdef1bc2ba1c783595b3c4af..1a8c5fe1c816ec9f7d473f4ec244e9df4aef1819 100644
--- a/components/storage_monitor/storage_monitor_chromeos.cc
+++ b/components/storage_monitor/storage_monitor_chromeos.cc
@@ -79,7 +79,7 @@ bool GetDeviceInfo(const DiskMountManager::MountPointInfo& mount_info,
// Returns whether the mount point in |mount_info| is a media device or not.
bool CheckMountedPathOnFileThread(
const DiskMountManager::MountPointInfo& mount_info) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
Cait (Slow) 2015/04/23 00:02:37 content::BrowserThread::FILE?
Mostyn Bramley-Moore 2015/04/23 07:43:16 The other DCHECK_CURRENTLY_ON's in this file don't
Mostyn Bramley-Moore 2015/04/23 08:15:09 Looks like it is needed after all- fixed in the la
return MediaStorageUtil::HasDcim(base::FilePath(mount_info.mount_path));
}

Powered by Google App Engine
This is Rietveld 408576698