favor DCHECK_CURRENTLY_ON for better logs in components/ (part 2)

components/storage_monitor/storage_monitor_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/storage_monitor/storage_monitor_chromeos.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/strings/string16.h"
@@ skipping 61 matching lines @@
                       device_label,
                       base::UTF8ToUTF16(disk->vendor_name()),
                       base::UTF8ToUTF16(disk->product_name()),
                       disk->total_size_in_bytes());
   return true;
 }
 
 // Returns whether the mount point in |mount_info| is a media device or not.
 bool CheckMountedPathOnFileThread(
     const DiskMountManager::MountPointInfo& mount_info) {
-  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+  DCHECK_CURRENTLY_ON(BrowserThread::FILE);

[Cait (Slow), 2015/04/23 00:02:37]

content::BrowserThread::FILE?

[Mostyn Bramley-Moore, 2015/04/23 07:43:16]

The other DCHECK_CURRENTLY_ON's in this file don't seem to need the content
namespace added here, so I think it's better to leave this one without it also. 
It's less to read, and I don't think it's dangerous or anything.

[Mostyn Bramley-Moore, 2015/04/23 08:15:09]

Looks like it is needed after all- fixed in the latest patchset.

I will adjust my sed script to be more careful about this.

   return MediaStorageUtil::HasDcim(base::FilePath(mount_info.mount_path));
 }
 
 }  // namespace
 
 using content::BrowserThread;
 
 StorageMonitorCros::StorageMonitorCros()
     : weak_ptr_factory_(this) {
 }
@@ skipping 204 matching lines @@
   mount_map_.insert(std::make_pair(mount_info.mount_path, info));
 
   receiver()->ProcessAttach(info);
 }
 
 StorageMonitor* StorageMonitor::CreateInternal() {
   return new StorageMonitorCros();
 }
 
 }  // namespace storage_monitor