Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 1043013002: favor DCHECK_CURRENTLY_ON for better logs in components/ (part 2) (Closed)

Created:
5 years, 8 months ago by Mostyn Bramley-Moore
Modified:
5 years, 8 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, jam, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in components/ (part 2) BUG=466848 Committed: https://crrev.com/9125861b525058c9b2b03d697ae16fa58a334e07 Cr-Commit-Position: refs/heads/master@{#326483}

Patch Set 1 #

Patch Set 2 : scoping fixup #

Patch Set 3 : rebase on master + add one more #

Total comments: 5

Patch Set 4 : improve namespace consistency #

Patch Set 5 : improve namespace consistency some more within each file #

Patch Set 6 : content namespace needed after all #

Messages

Total messages: 17 (8 generated)
Mostyn Bramley-Moore
@caitkp: please take a look...
5 years, 8 months ago (2015-04-21 09:48:06 UTC) #4
Cait (Slow)
LGTM nit: you use content::BrowserThread::FILE in some places and BrowserThread::FILE in others. Might be good ...
5 years, 8 months ago (2015-04-23 00:02:37 UTC) #5
Mostyn Bramley-Moore
This should be consistent within each file now. https://codereview.chromium.org/1043013002/diff/40001/components/storage_monitor/image_capture_device.mm File components/storage_monitor/image_capture_device.mm (right): https://codereview.chromium.org/1043013002/diff/40001/components/storage_monitor/image_capture_device.mm#newcode16 components/storage_monitor/image_capture_device.mm:16: DCHECK_CURRENTLY_ON(BrowserThread::FILE); ...
5 years, 8 months ago (2015-04-23 07:43:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043013002/80001
5 years, 8 months ago (2015-04-23 07:43:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/30237)
5 years, 8 months ago (2015-04-23 08:04:55 UTC) #11
Mostyn Bramley-Moore
https://codereview.chromium.org/1043013002/diff/40001/components/storage_monitor/storage_monitor_chromeos.cc File components/storage_monitor/storage_monitor_chromeos.cc (right): https://codereview.chromium.org/1043013002/diff/40001/components/storage_monitor/storage_monitor_chromeos.cc#newcode82 components/storage_monitor/storage_monitor_chromeos.cc:82: DCHECK_CURRENTLY_ON(BrowserThread::FILE); On 2015/04/23 07:43:16, Mostyn Bramley-Moore wrote: > On ...
5 years, 8 months ago (2015-04-23 08:15:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043013002/100001
5 years, 8 months ago (2015-04-23 08:15:47 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-23 09:26:34 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 09:27:31 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9125861b525058c9b2b03d697ae16fa58a334e07
Cr-Commit-Position: refs/heads/master@{#326483}

Powered by Google App Engine
This is Rietveld 408576698