Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1042923003: Fail gracefully when starting Chrome with an invalid kProfileDirectory.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by noms (inactive)
Modified:
2 years, 1 month ago
Reviewers:
noms, Mike Lerman, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fail gracefully when starting Chrome with an invalid kProfileDirectory. Thi would happen if you had an old Chrome/app shortcut. We shouldn't default to a different profile, since that might leave the user browsing under an incorrect profile (and thus accidentally leak private data), so we should show the User Manager instead (since this is what it's there for) BUG=460006

Patch Set 1 : #

Patch Set 2 : fix indent #

Total comments: 8

Patch Set 3 : mike comments #

Patch Set 4 : add a test #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Messages

Total messages: 15 (7 generated)
noms (inactive)
PTAL. Thanks!
2 years, 1 month ago (2015-03-31 19:56:35 UTC) #4
Mike Lerman
https://codereview.chromium.org/1042923003/diff/60001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/1042923003/diff/60001/chrome/browser/chrome_browser_main.cc#newcode356 chrome/browser/chrome_browser_main.cc:356: ProfileInfoCache& cache = nit: Can this be a const ...
2 years, 1 month ago (2015-03-31 20:48:30 UTC) #5
noms (inactive)
https://codereview.chromium.org/1042923003/diff/60001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/1042923003/diff/60001/chrome/browser/chrome_browser_main.cc#newcode356 chrome/browser/chrome_browser_main.cc:356: ProfileInfoCache& cache = On 2015/03/31 20:48:30, Mike Lerman wrote: ...
2 years, 1 month ago (2015-03-31 21:01:33 UTC) #6
Mike Lerman
lgtm
2 years, 1 month ago (2015-04-01 13:18:54 UTC) #7
noms
+ scott for owners stamp extravaganza on chrome/browser/chrome_browser_main.cc :)
2 years, 1 month ago (2015-04-01 13:38:17 UTC) #9
sky
Can you write tests for this?
2 years, 1 month ago (2015-04-01 16:12:39 UTC) #10
noms (inactive)
Scott: Added a test! I'm going to rebase and see why the bots are so ...
2 years, 1 month ago (2015-04-07 14:14:19 UTC) #11
sky
2 years, 1 month ago (2015-04-08 19:44:17 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06