Issue 1042863004: tweaks to build/test scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1042863004: tweaks to build/test scripts (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

tweaks to build/test scripts this is a follow up to reverted https://github.com/dart-lang/dev_compiler/pull/114 it relands it so it can pass on travis, with some additional tweaks to names The new structure is: tool/ presubmit.sh # both build and test build_sdk.sh test.sh coverage.sh test/test.sh # deprecated, with a warning message Thoughts? R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/529cfd61c735ff5047885f68398c97ad3d43b26a

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -114 lines)			Patch
M	.travis.yml	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/test.sh	View	1 chunk	+3 lines, -81 lines	0 comments	Download
A +	tool/coverage.sh	View	1 chunk	+2 lines, -7 lines	0 comments	Download
A	tool/presubmit.sh	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	tool/test.sh	View	2 chunks	+9 lines, -7 lines	0 comments	Download
D	tool/travis.sh	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

FYI, I pushed this to get Travis results @ https://travis-ci.org/dart-lang/dev_compiler/builds/56464863 not sure if it will ...

5 years, 8 months ago (2015-03-30 19:41:23 UTC) #2

Siggi Cherem (dart-lang)

lgtm, I like the overall structure, presubmit is a nice name.

5 years, 8 months ago (2015-03-30 19:43:27 UTC) #3

Jennifer Messerly

5 years, 8 months ago (2015-03-30 19:52:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
529cfd61c735ff5047885f68398c97ad3d43b26a (presubmit successful).