Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: tool/test.sh

Issue 1042863004: tweaks to build/test scripts (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/presubmit.sh ('k') | tool/travis.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/test.sh
diff --git a/test/test.sh b/tool/test.sh
similarity index 84%
copy from test/test.sh
copy to tool/test.sh
index 5e5fde2a622cc81666652e3c76380864f0932cf5..66240d60d69c0c450fb22072c8a92064bbe38c82 100755
--- a/test/test.sh
+++ b/tool/test.sh
@@ -24,17 +24,20 @@ function show_diff {
fail
}
-# the directory of this script
-TEST_DIR=$( cd $( dirname "${BASH_SOURCE[0]}" ) && pwd )
-
# Some tests require being run from the package root
-cd $TEST_DIR/..
+# switch to the root directory of dev_compiler
+cd $( dirname "${BASH_SOURCE[0]}" )/..
# Check minimum SDK version
./tool/sdk_version_check.dart 1.9.0-dev.4.0 || fail
-./tool/build_sdk.sh
-
+# Make sure we don't run tests in code coverage mode.
+# this will cause us to generate files that are not part of the baseline
+# TODO(jmesserly): we should move diff into Dart code, so we don't need to
+# worry about this. Also if we're in code coverage mode, we should avoid running
+# all_tests twice. Finally self_host_test is not currently being tracked by
+# code coverage.
+unset COVERALLS_TOKEN
dart -c test/all_tests.dart || fail
# validate codegen_test output
@@ -77,6 +80,5 @@ dartanalyzer --fatal-warnings --package-warnings bin/devc.dart | (! grep $PWD) \
tool/*.dart | grep -v lib/src/js/`; git status -s $files | grep -q . \
&& echo "Did not run the formatter, please commit edited files first." \
|| (echo "Running dart formatter" ; pub run dart_style:format -w $files))
-popd &> /dev/null
echo -e "All tests pass"
« no previous file with comments | « tool/presubmit.sh ('k') | tool/travis.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698