Issue 104263002: Remove TreatNullAs=NullString for Element.id and .className

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104263002: Remove TreatNullAs=NullString for Element.id and .className (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews), jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove TreatNullAs=NullString for Element.id and .className http://dom.spec.whatwg.org/#interface-element The tests for the updated properties FAIL in Firefox Nightly, IE11 Release Preview and Opera 12.16, with the exception of the id test in Firefox. This is because id and className are not on the Element interface in these browsers, if the test is modified to create a HTMLElement then tests for both attributes pass in all browsers. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163182

Patch Set 1 #

Patch Set 2 : update SVGElement.id test #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.idl	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/104263002/20001

7 years ago (2013-12-04 15:30:42 UTC) #4

Message was sent while issue was closed.

Change committed as 163182

Expand Messages | Collapse Messages