Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: Source/core/dom/Element.idl

Issue 104263002: Remove TreatNullAs=NullString for Element.id and .className (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update SVGElement.id test Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.idl
diff --git a/Source/core/dom/Element.idl b/Source/core/dom/Element.idl
index d85e3260bd665ea99e14278475ee07bdf0596ab8..a5eb5f4d873864ceacfd702ba838cd22db7167b3 100644
--- a/Source/core/dom/Element.idl
+++ b/Source/core/dom/Element.idl
@@ -57,9 +57,7 @@
[PerWorldBindings] readonly attribute CSSStyleDeclaration style;
// DOM4
- // iht.com relies on id returning the empty string when no id is present.
- // Other browsers do this as well. So we don't convert null to JS null.
- [Reflect, TreatNullAs=NullString] attribute DOMString id;
+ [Reflect] attribute DOMString id;
[TreatReturnedNullStringAs=Null, PerWorldBindings] readonly attribute DOMString namespaceURI;
[TreatReturnedNullStringAs=Null, TreatNullAs=NullString, PerWorldBindings, RaisesException=Setter] attribute DOMString prefix;
[TreatReturnedNullStringAs=Null, PerWorldBindings] readonly attribute DOMString localName;
@@ -95,7 +93,7 @@
[TreatNullAs=NullString, CustomElementCallbacks, PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds, RaisesException=Setter] attribute DOMString innerHTML;
[TreatNullAs=NullString, CustomElementCallbacks, RaisesException=Setter] attribute DOMString outerHTML;
- [Reflect=class, TreatNullAs=NullString, PerWorldBindings] attribute DOMString className;
+ [Reflect=class, PerWorldBindings] attribute DOMString className;
[PerWorldBindings] readonly attribute DOMTokenList classList;
[PerWorldBindings] readonly attribute DOMStringMap dataset;
« no previous file with comments | « LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698