Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1042003002: fix list literal initialization call fix typeof calls for primitive JS types add dart/collection.js… (Closed)

Created:
5 years, 9 months ago by Jacob
Modified:
5 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix list literal initialization call fix typeof calls for primitive JS types add dart/collection.js to defaultRuntimeFiles list Enclose switch statement case blocks with braces to insure a block scope matching dart semantics BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/61c3bde161667a827eb3c95aa8a01e4e24c98c08

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -194 lines) Patch
M lib/runtime/dart/_interceptors.js View 20 chunks +29 lines, -21 lines 0 comments Download
M lib/runtime/dart/_internal.js View 9 chunks +10 lines, -10 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 11 chunks +86 lines, -26 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 46 chunks +92 lines, -58 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 3 chunks +7 lines, -7 lines 0 comments Download
M lib/runtime/dart/async.js View 6 chunks +11 lines, -5 lines 0 comments Download
M lib/runtime/dart/collection.js View 15 chunks +15 lines, -15 lines 0 comments Download
M lib/runtime/dart/convert.js View 11 chunks +35 lines, -9 lines 0 comments Download
M lib/runtime/dart/core.js View 5 chunks +6 lines, -6 lines 0 comments Download
M lib/runtime/dart/isolate.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/math.js View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_runtime.js View 1 chunk +1 line, -0 lines 2 comments Download
M lib/src/codegen/js_codegen.dart View 3 chunks +3 lines, -8 lines 0 comments Download
M lib/src/dependency_graph.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/js/printer.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M test/codegen/expect/DeltaBlue.js View 9 chunks +10 lines, -10 lines 0 comments Download
M test/codegen/expect/cascade.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +4 lines, -3 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jacob
fix list literal initialization call fix typeof calls for primitive JS types add dart/collection.js to ...
5 years, 9 months ago (2015-03-27 23:44:44 UTC) #2
Jennifer Messerly
other than a fix in dart_runtime, LGTM! https://codereview.chromium.org/1042003002/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1042003002/diff/1/lib/runtime/dart_runtime.js#newcode268 lib/runtime/dart_runtime.js:268: this.map = ...
5 years, 8 months ago (2015-03-30 14:43:32 UTC) #3
Jacob
https://codereview.chromium.org/1042003002/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1042003002/diff/1/lib/runtime/dart_runtime.js#newcode268 lib/runtime/dart_runtime.js:268: this.map = map; On 2015/03/30 14:43:32, John Messerly wrote: ...
5 years, 8 months ago (2015-03-30 16:40:52 UTC) #4
Jacob
5 years, 8 months ago (2015-03-30 16:42:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
61c3bde161667a827eb3c95aa8a01e4e24c98c08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698