fix list literal initialization call fix typeof calls for primitive JS types add dart/collection.js…

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap;
 import 'dart:io' show Directory, File;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
@@ skipping 217 matching lines @@
       js.call('dart.as(#)', [[_visit(node), _emitTypeName(type)]]);
 
   @override
   visitIsExpression(IsExpression node) {
     // Generate `is` as `dart.is` or `typeof` depending on the RHS type.
     JS.Expression result;
     var type = node.type.type;
     var lhs = _visit(node.expression);
     var typeofName = _jsTypeofName(type);
     if (typeofName != null) {
-      result = js.call('typeof # == #', [lhs, typeofName]);
+      result = js.call('typeof # == #', [lhs, js.string(typeofName, "'")]);
     } else {
       // Always go through a runtime helper, because implicit interfaces.
       result = js.call('dart.is(#, #)', [lhs, _emitTypeName(type)]);
     }
 
     if (node.notOperator != null) {
       return js.call('!#', result);
     }
     return result;
   }
@@ skipping 1657 matching lines @@
 
   @override
   visitDoubleLiteral(DoubleLiteral node) => js.number(node.value);
 
   @override
   visitNullLiteral(NullLiteral node) => new JS.LiteralNull();
 
   @override
   visitListLiteral(ListLiteral node) {
     // TODO(jmesserly): make this faster. We're wasting an array.
-    var list = js.call('new List.from(#)',
-        [new JS.ArrayInitializer(_visitList(node.elements))]);
+    var list = js.call('new #.from(#)',
+        [_emitTypeName(node.staticType), new JS.ArrayInitializer(_visitList(node.elements))]);
     if (node.constKeyword != null) {
       list = js.commentExpression('Unimplemented const', list);
     }
     return list;
   }
 
   @override
   visitMapLiteral(MapLiteral node) {
     var entries = node.entries;
     var mapArguments = null;
@@ skipping 90 matching lines @@
     return _constEvaluator.evaluate(initializer);
   }
 
   _visit(AstNode node) {
     if (node == null) return null;
     var result = node.accept(this);
     if (result is JS.Node) result.sourceInformation = node;
     return result;
   }
 
-  JS.Statement _visitOrEmpty(Statement node) {
-    if (node == null) return new JS.EmptyStatement();
-    return _visit(node);
-  }
-
   List _visitList(Iterable<AstNode> nodes) {
     if (nodes == null) return null;
     var result = [];
     for (var node in nodes) result.add(_visit(node));
     return result;
   }
 
   /// Visits a list of expressions, creating a comma expression if needed in JS.
   JS.Expression _visitListToBinary(List<Expression> nodes, String operator) {
     if (nodes == null || nodes.isEmpty) return null;
@@ skipping 286 matching lines @@
 
     // TODO(jmesserly): in many cases marking the end will be unncessary.
     printer.mark(_location(node.end));
   }
 
   String _getIdentifier(AstNode node) {
     if (node is SimpleIdentifier) return node.name;
     return null;
   }
 }