Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1041953003: QUIC - Added the following finch trial parameters to disable QUIC if (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Added the following finch trial parameters to disable QUIC if the packet loss rate is bad for multiple connections in a row. + max_number_of_lossy_connections: specifies the maximum number of connections with high packet loss in a row after which QUIC will be disabled. + packet_loss_threshold: specifies packet loss rate in franction after which a connection is closed and is considered as a lossy connection. QUIC changes to support this were checked in the following CL: https://codereview.chromium.org/1025573002/ R=rch@chromium.org Committed: https://crrev.com/374e5688645005b741b2ef9037ee84a29f115706 Cr-Commit-Position: refs/heads/master@{#322704}

Patch Set 1 #

Patch Set 2 : Fixed typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M chrome/browser/io_thread.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-27 23:25:57 UTC) #1
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-28 03:15:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041953003/20001
5 years, 9 months ago (2015-03-28 13:46:55 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-28 13:50:02 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 13:50:40 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/374e5688645005b741b2ef9037ee84a29f115706
Cr-Commit-Position: refs/heads/master@{#322704}

Powered by Google App Engine
This is Rietveld 408576698