Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1041953003: QUIC - Added the following finch trial parameters to disable QUIC if (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 7b527bad90184455b9859f9265b75fdba25d74fc..cb6e64984a9199046777dca52fdedd40e0cd0e80 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -225,6 +225,8 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params.quic_enable_connection_racing);
EXPECT_FALSE(params.quic_enable_non_blocking_io);
EXPECT_FALSE(params.quic_disable_disk_cache);
+ EXPECT_EQ(0, params.quic_max_number_of_lossy_connections);
+ EXPECT_EQ(1.0f, params.quic_packet_loss_threshold);
EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
}
@@ -414,6 +416,24 @@ TEST_F(IOThreadTest, QuicDisableDiskCache) {
EXPECT_TRUE(params.quic_disable_disk_cache);
}
+TEST_F(IOThreadTest, QuicMaxNumberOfLossyConnectionsFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["max_number_of_lossy_connections"] = "5";
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_EQ(5, params.quic_max_number_of_lossy_connections);
+}
+
+TEST_F(IOThreadTest, QuicPacketLossThresholdFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["packet_loss_threshold"] = "0.5";
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_EQ(0.5f, params.quic_packet_loss_threshold);
+}
+
TEST_F(IOThreadTest, QuicReceiveBufferSize) {
field_trial_group_ = "Enabled";
field_trial_params_["receive_buffer_size"] = "1048576";
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698