Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1041853002: Land Recent QUIC Changes until 03/25/2015. (Closed)

Created:
5 years, 8 months ago by ramant (doing other things)
Modified:
5 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rch_patch_1036023002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes until 03/25/2015. A number of fixes to please clang_tidy. There should be no functional changes. Putting the construction of a "null" SerializedPacket into a function rather than constructing one into a local variable everywhere one is needed. Renaming class members to end with "_". Taking the initial "k" off local variables. Merge internal change: 89397417 https://codereview.chromium.org/1039473003/ Move test for incoming packets with incorrect connection ID from QuicConnection::OnPacketHeader to ::OnUnauthenticatedPublicHeader so it works. Add tests to verify code handles incoming packets with invalid connection IDs. Add DCHECKs to verify that QuicConnection::OnPublicResetPacket and ::OnVersionNegotiationPacket don't get packets with invalid connection IDs. Add comment to QuicConnection::ProcessUdpPacket to note packet may have incorrect connection ID. Fix b/19710533. Merge internal change: 89336249 https://codereview.chromium.org/1038293002/ Fix a flaky QUIC end to end test by supplying the correct buffer size as the initial default. Merge internal change: 89220759 https://codereview.chromium.org/1038223002/ Initialize slowstart_packets_sent. Avoid uninitialized memory. Merge internal change: 89126237 https://codereview.chromium.org/1036123002/ QUIC - minor cleanup while merging the following change. In Chromium's AddToCache function, we use "www.google.com" instead of empty path as it was done in the internal CL. All other changes were already merged by rch. Make some changes to the QuicInMemory server to clarify the interface. Specifically that the cache is indexed by host and path, not by method nor scheme, nor full URL, nor request headers, etc. In preparation for making the chrome version more similar. Merge internal change: 89092881 https://codereview.chromium.org/1038203002/ R=rch@chromium.org Committed: https://crrev.com/95293808942643749bb054446e915f22937a2e97 Cr-Commit-Position: refs/heads/master@{#322616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -91 lines) Patch
M net/quic/congestion_control/send_algorithm_interface.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 4 chunks +27 lines, -12 lines 0 comments Download
M net/quic/quic_connection_stats.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +45 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +90 lines, -2 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 8 months ago (2015-03-27 17:25:55 UTC) #1
Ryan Hamilton
lgtm
5 years, 8 months ago (2015-03-27 18:54:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041853002/1
5 years, 8 months ago (2015-03-27 18:55:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-27 18:59:30 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 19:00:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95293808942643749bb054446e915f22937a2e97
Cr-Commit-Position: refs/heads/master@{#322616}

Powered by Google App Engine
This is Rietveld 408576698