Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: net/quic/quic_packet_creator.cc

Issue 1041853002: Land Recent QUIC Changes until 03/25/2015. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rch_patch_1036023002
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_creator.h ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator.cc
diff --git a/net/quic/quic_packet_creator.cc b/net/quic/quic_packet_creator.cc
index ac2a94e5908ebfc060206a4a67fa7e43520cc236..3d6b7948d2c9c7d6ff7e2fffce845142b88e83ff 100644
--- a/net/quic/quic_packet_creator.cc
+++ b/net/quic/quic_packet_creator.cc
@@ -399,9 +399,7 @@ SerializedPacket QuicPacketCreator::SerializePacket() {
framer_->EncryptPacket(encryption_level_, sequence_number_, *packet);
if (encrypted == nullptr) {
LOG(DFATAL) << "Failed to encrypt packet number " << sequence_number_;
- SerializedPacket kNoPacket(0, PACKET_1BYTE_SEQUENCE_NUMBER, nullptr, 0,
- nullptr);
- return kNoPacket;
+ return NoPacket();
}
packet_size_ = 0;
@@ -416,9 +414,7 @@ SerializedPacket QuicPacketCreator::SerializeFec() {
if (fec_group_.get() == nullptr || fec_group_->NumReceivedPackets() <= 0) {
LOG(DFATAL) << "SerializeFEC called but no group or zero packets in group.";
// TODO(jri): Make this a public method of framer?
- SerializedPacket kNoPacket(0, PACKET_1BYTE_SEQUENCE_NUMBER, nullptr, 0,
- nullptr);
- return kNoPacket;
+ return NoPacket();
}
DCHECK_EQ(0u, queued_frames_.size());
QuicPacketHeader header;
@@ -438,9 +434,7 @@ SerializedPacket QuicPacketCreator::SerializeFec() {
framer_->EncryptPacket(encryption_level_, sequence_number_, *packet);
if (encrypted == nullptr) {
LOG(DFATAL) << "Failed to encrypt packet number " << sequence_number_;
- SerializedPacket kNoPacket(0, PACKET_1BYTE_SEQUENCE_NUMBER, nullptr, 0,
- nullptr);
- return kNoPacket;
+ return NoPacket();
}
SerializedPacket serialized(
header.packet_sequence_number,
@@ -465,6 +459,10 @@ QuicEncryptedPacket* QuicPacketCreator::SerializeVersionNegotiationPacket(
return encrypted;
}
+SerializedPacket QuicPacketCreator::NoPacket() {
+ return SerializedPacket(0, PACKET_1BYTE_SEQUENCE_NUMBER, nullptr, 0, nullptr);
+}
+
void QuicPacketCreator::FillPacketHeader(QuicFecGroupNumber fec_group,
bool fec_flag,
QuicPacketHeader* header) {
« no previous file with comments | « net/quic/quic_packet_creator.h ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698