Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1041673002: Remove "easy" android_webview_build conditions from components. (Closed)

Created:
5 years, 9 months ago by Torne
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "easy" android_webview_build conditions from components. Remove references to android_webview_build now that we no longer support that build configuration. Fold conditions into their parents where appropriate. This CL only handles the "easy" cases, I'll do the nontrivial ones separately. BUG=440793 Committed: https://crrev.com/0b2cdd646a2e72c3df158b27974dc9647926d340 Cr-Commit-Position: refs/heads/master@{#323490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -256 lines) Patch
M components/components.gyp View 5 chunks +10 lines, -16 lines 0 comments Download
M components/crash.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller.gypi View 2 chunks +209 lines, -213 lines 0 comments Download
M components/resources/components_resources.grd View 1 chunk +1 line, -3 lines 0 comments Download
M components/sessions.gypi View 4 chunks +2 lines, -12 lines 0 comments Download
M components/sessions/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Torne
5 years, 9 months ago (2015-03-27 11:43:22 UTC) #2
Torne
5 years, 8 months ago (2015-04-02 11:04:36 UTC) #4
sdefresne
lgtm
5 years, 8 months ago (2015-04-02 14:28:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041673002/1
5 years, 8 months ago (2015-04-02 14:31:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 15:14:31 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:25:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b2cdd646a2e72c3df158b27974dc9647926d340
Cr-Commit-Position: refs/heads/master@{#323490}

Powered by Google App Engine
This is Rietveld 408576698