Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: components/sessions/BUILD.gn

Issue 1041673002: Remove "easy" android_webview_build conditions from components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sessions.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 # TODO(rohitrao): sessions_core is defined as a source_set because it declares a 9 # TODO(rohitrao): sessions_core is defined as a source_set because it declares a
10 # static function that it does not define. This prevents it from linking as a 10 # static function that it does not define. This prevents it from linking as a
(...skipping 19 matching lines...) Expand all
30 "session_service_commands.h", 30 "session_service_commands.h",
31 "session_types.cc", 31 "session_types.cc",
32 "session_types.h", 32 "session_types.h",
33 ] 33 ]
34 34
35 defines = [ "SESSIONS_IMPLEMENTATION" ] 35 defines = [ "SESSIONS_IMPLEMENTATION" ]
36 36
37 deps = [ 37 deps = [
38 "//base", 38 "//base",
39 "//skia", 39 "//skia",
40 "//sync",
40 "//third_party/protobuf:protobuf_lite", 41 "//third_party/protobuf:protobuf_lite",
41 "//ui/base", 42 "//ui/base",
42 "//ui/gfx", 43 "//ui/gfx",
43 "//url", 44 "//url",
44 ] 45 ]
45
46 if (!is_android || !is_android_webview_build) {
47 deps += [ "//sync" ]
48 }
49 } 46 }
50 47
51 source_set("test_support") { 48 source_set("test_support") {
52 testonly = true 49 testonly = true
53 sources = [ 50 sources = [
54 "serialized_navigation_entry_test_helper.cc", 51 "serialized_navigation_entry_test_helper.cc",
55 "serialized_navigation_entry_test_helper.h", 52 "serialized_navigation_entry_test_helper.h",
56 ] 53 ]
57 54
58 deps = [ 55 deps = [
59 ":sessions_core", 56 ":sessions_core",
60 "//skia", 57 "//skia",
58 "//sync",
61 "//testing/gtest", 59 "//testing/gtest",
62 ] 60 ]
63 61
64 if (!is_android || !is_android_webview_build) {
65 deps += [ "//sync" ]
66 }
67
68 if (!is_android && !is_ios) { 62 if (!is_android && !is_ios) {
69 sources += [ 63 sources += [
70 "base_session_service_test_helper.cc", 64 "base_session_service_test_helper.cc",
71 "base_session_service_test_helper.h", 65 "base_session_service_test_helper.h",
72 ] 66 ]
73 } 67 }
74 } 68 }
75 69
76 if (!is_ios) { 70 if (!is_ios) {
77 component("sessions_content") { 71 component("sessions_content") {
(...skipping 25 matching lines...) Expand all
103 "session_types_unittest.cc", 97 "session_types_unittest.cc",
104 ] 98 ]
105 deps = [ 99 deps = [
106 ":sessions_content", 100 ":sessions_content",
107 "//base/test:test_support", 101 "//base/test:test_support",
108 "//testing/gtest", 102 "//testing/gtest",
109 "//third_party/protobuf:protobuf_lite", 103 "//third_party/protobuf:protobuf_lite",
110 ] 104 ]
111 } 105 }
112 } 106 }
OLDNEW
« no previous file with comments | « components/sessions.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698