Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: Source/web/RemoteFrameClientImpl.cpp

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tests and cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/RemoteFrameClientImpl.cpp
diff --git a/Source/web/RemoteFrameClientImpl.cpp b/Source/web/RemoteFrameClientImpl.cpp
index a2994e71cb2f15f2ddc09e27d439474fba297eb6..c9ef4e99d1b8775d79c783535f71188fddbd8b1f 100644
--- a/Source/web/RemoteFrameClientImpl.cpp
+++ b/Source/web/RemoteFrameClientImpl.cpp
@@ -35,7 +35,7 @@ void RemoteFrameClientImpl::willBeDetached()
{
}
-void RemoteFrameClientImpl::detached()
+void RemoteFrameClientImpl::detached(DetachType type)
{
// Alert the client that the frame is being detached.
RefPtrWillBeRawPtr<WebRemoteFrameImpl> protector(m_webFrame);
@@ -44,7 +44,7 @@ void RemoteFrameClientImpl::detached()
if (!client)
return;
- client->frameDetached();
+ client->frameDetached(static_cast<WebRemoteFrameClient::DetachType>(type));
dcheng 2015/06/04 00:58:23 There should probably be something in AssertMatchi
lfg 2015/06/04 19:16:58 Done.
// Clear our reference to RemoteFrame at the very end, in case the client
// refers to it.
m_webFrame->setCoreFrame(nullptr);

Powered by Google App Engine
This is Rietveld 408576698