Source/web/RemoteFrameClientImpl.h - Issue 1041473002: Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/RemoteFrameClientImpl.h

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tests and cleanup Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/RemoteFrameClientImpl.h

diff --git a/Source/web/RemoteFrameClientImpl.h b/Source/web/RemoteFrameClientImpl.h

index 2889464a27a64d1b68747e4a0548e887016e87f7..9987461ce15e5c34ff53da764a2783c5ec576c86 100644

--- a/Source/web/RemoteFrameClientImpl.h

+++ b/Source/web/RemoteFrameClientImpl.h

@@ -17,7 +17,7 @@ public:

// FrameClient overrides:

virtual bool inShadowTree() const override;

virtual void willBeDetached() override;

- virtual void detached() override;

+ virtual void detached(DetachType) override;

virtual Frame* opener() const override;

virtual void setOpener(Frame*) override;

virtual Frame* parent() const override;