Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: Source/core/page/PrintContextTest.cpp

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tests and cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PrintContextTest.cpp
diff --git a/Source/core/page/PrintContextTest.cpp b/Source/core/page/PrintContextTest.cpp
index 67d116405aa1c783e50d2f08cbc3662926d0c06c..9340f01ee2443360dabda038cab9d0edfa40d3ec 100644
--- a/Source/core/page/PrintContextTest.cpp
+++ b/Source/core/page/PrintContextTest.cpp
@@ -327,7 +327,7 @@ TEST_F(PrintContextFrameTest, WithSubframe)
EXPECT_EQ(MockCanvas::DrawRect, operations[1].type);
EXPECT_SKRECT_EQ(350, 360, 270, 280, operations[1].rect);
- subframe->detach();
+ subframe->detach(DetachType::Remove);
static_cast<SingleChildFrameLoaderClient*>(document().frame()->client())->setChild(nullptr);
document().frame()->host()->decrementSubframeCount();
}
@@ -370,7 +370,7 @@ TEST_F(PrintContextFrameTest, WithScrolledSubframe)
EXPECT_EQ(MockCanvas::DrawRect, operations[2].type);
EXPECT_SKRECT_EQ(250, 260, 270, 280, operations[2].rect);
- subframe->detach();
+ subframe->detach(DetachType::Remove);
static_cast<SingleChildFrameLoaderClient*>(document().frame()->client())->setChild(nullptr);
document().frame()->host()->decrementSubframeCount();
}

Powered by Google App Engine
This is Rietveld 408576698