Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/page/Page.cpp

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tests and cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/Frame.h ('K') | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/PrintContextTest.cpp » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index d6dce00d7e23641a0ce0ba76e554ed194877c732..a6c0136e4c356fd59e247e1fc687f73d84a96aa7 100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -557,7 +557,7 @@ void Page::willBeDestroyed()
{
RefPtrWillBeRawPtr<Frame> mainFrame = m_mainFrame;
- mainFrame->detach();
+ mainFrame->detach(DetachType::Remove);
if (mainFrame->isLocalFrame()) {
toLocalFrame(mainFrame.get())->setView(nullptr);
« Source/core/frame/Frame.h ('K') | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/PrintContextTest.cpp » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698