Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: media/formats/webm/webm_audio_client.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/webm/webm_audio_client.cc
diff --git a/media/formats/webm/webm_audio_client.cc b/media/formats/webm/webm_audio_client.cc
index 92bb40f0ace1be47ed4d346c628e41c4d5702cb7..ea911ec290e8f3a3d28501c4916aefeb7912e6ac 100644
--- a/media/formats/webm/webm_audio_client.cc
+++ b/media/formats/webm/webm_audio_client.cc
@@ -37,7 +37,7 @@ bool WebMAudioClient::InitializeConfig(
} else if (codec_id == "A_OPUS") {
audio_codec = kCodecOpus;
} else {
- MEDIA_LOG(log_cb_) << "Unsupported audio codec_id " << codec_id;
+ MEDIA_LOG(ERROR, log_cb_) << "Unsupported audio codec_id " << codec_id;
return false;
}
@@ -51,7 +51,7 @@ bool WebMAudioClient::InitializeConfig(
ChannelLayout channel_layout = GuessChannelLayout(channels_);
if (channel_layout == CHANNEL_LAYOUT_UNSUPPORTED) {
- MEDIA_LOG(log_cb_) << "Unsupported channel count " << channels_;
+ MEDIA_LOG(ERROR, log_cb_) << "Unsupported channel count " << channels_;
return false;
}
@@ -100,9 +100,9 @@ bool WebMAudioClient::InitializeConfig(
bool WebMAudioClient::OnUInt(int id, int64 val) {
if (id == kWebMIdChannels) {
if (channels_ != -1) {
- MEDIA_LOG(log_cb_) << "Multiple values for id " << std::hex << id
- << " specified. (" << channels_ << " and " << val
- << ")";
+ MEDIA_LOG(ERROR, log_cb_) << "Multiple values for id " << std::hex << id
+ << " specified. (" << channels_ << " and "
+ << val << ")";
return false;
}
@@ -129,8 +129,9 @@ bool WebMAudioClient::OnFloat(int id, double val) {
return false;
if (*dst != -1) {
- MEDIA_LOG(log_cb_) << "Multiple values for id " << std::hex << id
- << " specified (" << *dst << " and " << val << ")";
+ MEDIA_LOG(ERROR, log_cb_) << "Multiple values for id " << std::hex << id
+ << " specified (" << *dst << " and " << val
+ << ")";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698