Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: media/formats/mpeg/mpeg_audio_stream_parser_base.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mpeg/mpeg_audio_stream_parser_base.cc
diff --git a/media/formats/mpeg/mpeg_audio_stream_parser_base.cc b/media/formats/mpeg/mpeg_audio_stream_parser_base.cc
index 2a5895f5a47d1462f5cb6b2f2660eff3d06d53af..14fe143c79184002463a19989c9c6c778eb03d87 100644
--- a/media/formats/mpeg/mpeg_audio_stream_parser_base.cc
+++ b/media/formats/mpeg/mpeg_audio_stream_parser_base.cc
@@ -262,7 +262,7 @@ int MPEGAudioStreamParserBase::ParseIcecastHeader(const uint8* data, int size) {
int offset = LocateEndOfHeaders(data, locate_size, 4);
if (offset < 0) {
if (locate_size == kMaxIcecastHeaderSize) {
- MEDIA_LOG(log_cb_) << "Icecast header is too large.";
+ MEDIA_LOG(ERROR, log_cb_) << "Icecast header is too large.";
return -1;
}
@@ -323,7 +323,7 @@ bool MPEGAudioStreamParserBase::ParseSyncSafeInt(BitReader* reader,
for (int i = 0; i < 4; ++i) {
uint8 tmp;
if (!reader->ReadBits(1, &tmp) || tmp != 0) {
- MEDIA_LOG(log_cb_) << "ID3 syncsafe integer byte MSb is not 0!";
+ MEDIA_LOG(ERROR, log_cb_) << "ID3 syncsafe integer byte MSb is not 0!";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698